Fix tls.py assertion issues. #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't figured out how to run the tests with -O yet, so consider this a draft. Everything passes for me without -O, and the problem my test server was having when run with -O went away. Arguably it would be good to add test coverage for the various kinds of input problems that can now cause TLS alerts, but I haven't figured out how to do those yet. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #435 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 25 25
Lines 4840 4864 +24
=========================================
+ Hits 4840 4864 +24 ☔ View full report in Codecov by Sentry. |
jlaine
reviewed
Dec 28, 2023
jlaine
reviewed
Dec 28, 2023
jlaine
force-pushed
the
asserts
branch
9 times, most recently
from
512df3b to
b5e29c2
Compare
1) Some assertions had side effects and would cause a loss of framing if python was run with -O or -OO 2) Some assertions should have been error checks. Co-authored-by: Jeremy Lainé <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some assertions had side effects and would cause a loss of
framing if python was run with -O or -OO
Some assertions should have been error checks.